Repository navigation
Conversation
lacatoire
reviewed
Oct 26, 2026
Comment on lines
+57
to
+59
| <literal>criticalExtensions</literal> is present only when the certificate | ||
| has at least one critical extension. Every other key listed below is always | ||
| present. |
Member
There was a problem hiding this comment.
Suggested change
| <literal>criticalExtensions</literal> is present only when the certificate | |
| has at least one critical extension. Every other key listed below is always | |
| present. | |
| Every other key listed below is always present. |
lacatoire
reviewed
Oct 26, 2026
Comment on lines
+215
to
+224
| <row> | ||
| <entry><literal>criticalExtensions</literal></entry> | ||
| <entry><type>array</type></entry> | ||
| <entry> | ||
| Numerically indexed list of extension names that are marked | ||
| critical, using the same names as the keys of | ||
| <literal>extensions</literal>. Only present when the certificate | ||
| has at least one critical extension. | ||
| </entry> | ||
| </row> |
Member
There was a problem hiding this comment.
Suggested change
| <row> | |
| <entry><literal>criticalExtensions</literal></entry> | |
| <entry><type>array</type></entry> | |
| <entry> | |
| Numerically indexed list of extension names that are marked | |
| critical, using the same names as the keys of | |
| <literal>extensions</literal>. Only present when the certificate | |
| has at least one critical extension. | |
| </entry> | |
| </row> |
criticalExtensions is not set by openssl_x509_parse() in any released version, so the key and its sentence should be dropped.
lacatoire
reviewed
Oct 26, 2026
| <entry><literal>serialNumber</literal></entry> | ||
| <entry><type>string</type></entry> | ||
| <entry> | ||
| Decimal representation of the serial number. |
Member
There was a problem hiding this comment.
Suggested change
| Decimal representation of the serial number. | |
| Decimal representation of the serial number. Large serial numbers are | |
| returned as a hexadecimal string prefixed with <literal>0x</literal> instead. |
the conversion is done by OpenSSL, so very large serials come back as 0x… rather than decimal.
lacatoire
reviewed
Oct 26, 2026
Comment on lines
+210
to
+211
| no short name. Each value is printable text describing that | ||
| extension. Which keys are present depends on the certificate. |
Member
There was a problem hiding this comment.
Suggested change
| no short name. Each value is printable text describing that | |
| extension. Which keys are present depends on the certificate. | |
| no short name. Each value is text describing that extension, or the raw | |
| extension data when it cannot be printed. Which keys are present depends on the certificate. |
extensions that OpenSSL cannot print, such as unknown OIDs, are returned as raw bytes, not text.
lacatoire
requested changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.